-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Python 3.13 and drop 3.8 #24
Conversation
WalkthroughThe changes in this pull request involve updates to the CI workflow, Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
pyproject.toml (1)
Line range hint
14-24
: Consider reordering Python version classifiers.The version changes are correct, but the classifiers could be more readable if ordered sequentially.
"Intended Audience :: Developers", "License :: OSI Approved :: MIT License", "Operating System :: OS Independent", + "Programming Language :: Python", + "Programming Language :: Python :: 3", + "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", "Programming Language :: Python :: 3.12", - "Programming Language :: Python :: 3.13", - "Programming Language :: Python :: 3.9", - "Programming Language :: Python :: 3", - "Programming Language :: Python", + "Programming Language :: Python :: 3.13"README.md (1)
Line range hint
279-281
: LGTM: Good references for Python version support decisionsThe section provides valuable references to official Python version status and NEP 29 for making informed decisions about version support.
Consider adding a link to Python's Status of Python Branches for more detailed information about Python version support timelines.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (3)
.github/workflows/ci.yaml
(1 hunks)README.md
(2 hunks)pyproject.toml
(3 hunks)
🔇 Additional comments (5)
.github/workflows/ci.yaml (1)
41-41
:
Review Python version matrix changes
The changes raise two concerns:
- The addition of Python 3.13 is not mentioned in the PR objective which only states "add support for Python 3.12 and drop 3.8"
- Python 3.13 is currently in alpha stage and might be unstable. Consider waiting for its stable release before adding it to the test matrix.
Let's verify the Python 3.13 release status:
Suggested changes:
- python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
+ python-version: ["3.9", "3.10", "3.11", "3.12"]
pyproject.toml (1)
11-11
: LGTM: Minimum Python version requirement updated correctly.
The change from ">=3.8" to ">=3.9" aligns with the PR objective to drop Python 3.8 support.
README.md (3)
40-58
: LGTM: Dependencies updated with specific version constraints
The default environment dependencies have been updated with explicit minimum version requirements, which is a good practice for dependency management.
156-156
: LGTM: Clear Python version requirement statement
The statement clearly communicates the new minimum Python version requirement of 3.9 and provides good guidance about using the latest stable version.
60-73
: Verify Python version compatibility claims
The test matrix has been updated to include Python 3.12 and 3.13 while removing 3.8. Let's verify this aligns with the project configuration.
✅ Verification successful
Python version configuration is consistent across the project
The test matrix changes align perfectly with the project's configuration:
pyproject.toml
specifiesrequires-python = ">=3.9"
, confirming the removal of Python 3.8 support- CI workflow in
.github/workflows/ci.yaml
includes all test matrix versions: 3.9, 3.10, 3.11, 3.12, and 3.13 - The test environments listed in the README table match exactly with the CI matrix Python versions
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify Python version configuration consistency across the project
# Check pyproject.toml for Python version requirements
echo "Checking Python version requirements in pyproject.toml..."
rg "requires-python|python_version" pyproject.toml
# Check CI workflow for Python versions
echo -e "\nChecking Python versions in CI workflow..."
rg "python-version" .github/workflows/
Length of output: 1034
@@ -108,7 +108,7 @@ extra-dependencies = ["pytest-randomly", "pytest-rerunfailures", "pytest-xdist"] | |||
extended = "test -n auto --reruns 7 --reruns-delay 1 {args}" | |||
|
|||
[[tool.hatch.envs.test.matrix]] | |||
python = ["3.8", "3.9", "3.10", "3.11", "3.12"] | |||
python = ["3.9", "3.10", "3.11", "3.12", "3.13"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Python 3.13 is not yet supported in GitHub Actions
While Python 3.13 is included in the test matrix, it's currently not available in GitHub Actions. The latest available version is 3.14.0-alpha, but it's an unstable development version. The workflows are currently using Python 3.12, which is the latest stable version.
- Remove Python 3.13 from the test matrix in
pyproject.toml
as it's not yet supported - Consider re-adding it once it becomes available in GitHub Actions setup-python action
🔗 Analysis chain
Verify Python 3.13 availability in CI environment.
The test matrix updates correctly reflect the version changes, but since Python 3.13 is still in development, we should verify its availability in the CI environment.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if GitHub Actions supports Python 3.13
gh api repos/actions/python-versions/releases/latest --jq '.tag_name' || \
echo "Failed to fetch Python versions. Please verify Python 3.13 support in your CI environment manually."
Length of output: 96
Script:
#!/bin/bash
# Check GitHub Actions workflow files for Python setup
fd -e yml -e yaml . .github/workflows/ -x cat {} \; | grep -A 5 "setup-python"
Length of output: 932
Summary by CodeRabbit