Dropped support for Python 3.8 #73
Conversation
WalkthroughThis pull request focuses on updating the project's Python version compatibility, removing support for Python 3.8 across multiple configuration files. The changes span the CI workflow, project configuration (pyproject.toml), and a minor import modification in the io.py file. The project is now targeting Python 3.9 and newer versions, with corresponding updates to testing matrices, classifiers, and import statements. Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
xcompact3d_toolbox/io.py (1)
10-10: Consider moving Iterator import to type-checking blockSince
Iteratoris only used for type hints, consider moving it to a type-checking block for better runtime performance:-from collections.abc import Iterator +from __future__ import annotations + +from typing import TYPE_CHECKING + +if TYPE_CHECKING: + from collections.abc import IteratorThis change:
- Improves runtime performance by avoiding unnecessary imports
- Follows type hinting best practices
- Addresses the static analysis suggestion
🧰 Tools
🪛 Ruff (0.8.2)
10-10: Move standard library import
collections.abc.Iteratorinto a type-checking blockMove into type-checking block
(TC003)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/ci.yaml(2 hunks)pyproject.toml(2 hunks)xcompact3d_toolbox/io.py(1 hunks)
🧰 Additional context used
🪛 Ruff (0.8.2)
xcompact3d_toolbox/io.py
10-10: Move standard library import collections.abc.Iterator into a type-checking block
Move into type-checking block
(TC003)
🔇 Additional comments (4)
.github/workflows/ci.yaml (2)
29-29: LGTM: Python version matrix updated correctly
The test matrix has been updated to remove Python 3.8, now only including versions 3.9 through 3.12.
89-89: LGTM: SonarCloud scan parameters aligned with supported versions
The SonarCloud Python version parameter has been updated to match the supported versions (3.9-3.12).
pyproject.toml (2)
9-9: LGTM: Python version requirement updated
The requires-python field has been correctly updated to require Python 3.9 or newer.
148-148: LGTM: Test matrix versions aligned
The test matrix has been updated to match the new minimum Python version requirement.
fschuch
force-pushed
the
chore/droped-support-for-python-3.8
branch
from
851de63 to
45dee17
Compare
|
Summary by CodeRabbit
New Features
Bug Fixes
Chores