-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC FS-1033 - Deprecate places where seq
can be omitted.
#788
Open
edgarfgp
wants to merge
5
commits into
fsharp:main
Choose a base branch
from
edgarfgp:deprecate-places-where-seq-can-be-omitted
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
RFC FS-1033 - Deprecate places where seq
can be omitted.
#788
edgarfgp
wants to merge
5
commits into
fsharp:main
from
edgarfgp:deprecate-places-where-seq-can-be-omitted
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
edgarfgp
force-pushed
the
deprecate-places-where-seq-can-be-omitted
branch
from
October 4, 2024 19:38
cefeb1b
to
51654bf
Compare
edgarfgp
force-pushed
the
deprecate-places-where-seq-can-be-omitted
branch
from
October 4, 2024 19:48
51654bf
to
2014d76
Compare
Martin521
approved these changes
Oct 4, 2024
let (..) _ _ = "Im an index range operator" | ||
|
||
let x = { 1..10 } // Here the index range operator is being overridden and `x` will be a string instead of a sequence. | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will that be different when using seq {1..10}
? According to the spec, also in this case the (..)
operator will be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- With index range operator being overridden
let (..) _ _ = "Im an index range operator"
{ 1..10 } // inferred as string
let str = { 1..10 } // inferred as string
let charSeq = seq { 1..10 } // inferred as char seq
- Without index range operator being overridden
{ 1..10 } // inferred as int seq
let str = { 1..10 } // inferred as int seq
let intSeq = seq { 1..10 } // inferred as int seq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Click “Files changed” → “⋯” → “View file” for the rendered RFC.