Modify logging module #43
Conversation
alluxiofs/core.py
Outdated
| @@ -120,6 +116,17 @@ def __init__( | |||
| if preload_path is not None: | |||
| self.alluxio.load(preload_path) | |||
|
|
|||
| if "log_level" in test_options: | |||
There was a problem hiding this comment.
think u should include in the options
There was a problem hiding this comment.
alluxiofs is an inner Python module
For each Python process, the end launch program should define to log level, and all the inner Python module inherit the logging configuration.
E.g. in our benchmark entry point, we should define the log level and log file there
There was a problem hiding this comment.
no I meant to say why not use the dict "options" ? its also user defined at time of instantiating alluxiofs instance right?
alluxiofs/core.py
Outdated
| elif log_level == "WARN" or log_level == "WARNING": | ||
| logger.setLevel(logging.WARN) | ||
| else: | ||
| logger.warning(f"Unsupported log level: {log_level}") |
There was a problem hiding this comment.
and lets set a default warning level to be ERROR (logging has ERROR level correct? )
There was a problem hiding this comment.
logging usually don't have error, if it's error, the program should directly error out and failed
but they do have error log level
alluxiofs/core.py
Outdated
| start_time = time.time() | ||
| res = alluxio_impl(self, path, *args, **kwargs) | ||
| self.logger.debug( | ||
| f"Successfully called {alluxio_impl.__name__} against alluxio server with args ({args}), kwargs ({kwargs}) for {time.time() - start_time} ms" |
There was a problem hiding this comment.
this time.time() is in sec
|
@ChunxuTang @lucyge2022 PTAL thanks! |
No description provided.