Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Alluxio Configuration Approach #52

Merged
merged 8 commits into from
Jul 24, 2024
Merged

Conversation

SibylYang
Copy link
Collaborator

Built upon previous PR. Addressed comments regarding changing to asserts in config.py.

Copy link
Collaborator

@LuQQiu LuQQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments, thanks for making the configuration look much better

alluxiofs/core.py Outdated Show resolved Hide resolved
alluxiofs/core.py Outdated Show resolved Hide resolved
alluxiofs/client/worker_ring.py Outdated Show resolved Hide resolved
alluxiofs/client/core.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@LuQQiu LuQQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@LuQQiu LuQQiu merged commit ce10281 into fsspec:main Jul 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants