Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix import type declaration not found #39

Merged
merged 1 commit into from
Feb 15, 2025
Merged

Conversation

RRosio
Copy link
Collaborator

@RRosio RRosio commented Nov 22, 2024

Although CI passes there is an error:

Failed to collect coverage from /home/runner/work/jupyter-fsspec/jupyter-fsspec/src/index.ts
ERROR: src/index.ts:1:23 - error TS2307: Cannot find module 'path' or its corresponding type declarations.

1 import * as path from 'path';
  • Added resolution for node types

@RRosio RRosio added the maintenance General tasks for project upkeep label Nov 22, 2024
@RRosio RRosio marked this pull request as ready for review February 15, 2025 07:24
@RRosio
Copy link
Collaborator Author

RRosio commented Feb 15, 2025

The import error is no longer present in the test run:
Screenshot 2025-02-14 at 11 23 56 PM
I'll go ahead and merge this fix!

@RRosio RRosio changed the title [WIP] CI: Fix import type declaration not found CI: Fix import type declaration not found Feb 15, 2025
@RRosio RRosio merged commit 64a1d07 into fsspec:main Feb 15, 2025
8 checks passed
@RRosio RRosio deleted the path_import branch February 15, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance General tasks for project upkeep
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant