Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pyproject toml and importlib.metadata #379

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

maxrjones
Copy link
Contributor

Follows up on the recommendation in #372 (comment) to use pyproject.toml rather than setup.py + setup.cfg.

Still need to check whether there's any impacts from the deprecation of cmdclass and switch from versioneer to importlib.metadata.

@martindurant
Copy link
Member

Do you intend to do more here before taking off "WIP"?

@maxrjones
Copy link
Contributor Author

Do you intend to do more here before taking off "WIP"?

Yes, want to double check on this:

check whether there's any impacts from the deprecation of cmdclass and switch from versioneer to importlib.metadata.

I'll ping for a review after getting to that (should be tomorrow morning)

@martindurant
Copy link
Member

I would like to release today or this weekend, so it would be nice to make use of this work

@maxrjones
Copy link
Contributor Author

I would like to release today or this weekend, so it would be nice to make use of this work

Looking now

@maxrjones maxrjones changed the title WIP: Use pyproject toml and importlib.metadata Use pyproject toml and importlib.metadata Oct 20, 2023
@maxrjones
Copy link
Contributor Author

@martindurant the version format from setuptools_scm (e.g., 0.2.0.post62) differs from the prior versioneer setup (e.g., 0.2.0+59.gff2d639). The options from setuptools_scm include guessing the next minor version and appending the commit hash. Please let me know if you'd rather a different format. Otherwise, the passing tests and a quick check on the version suggests this is good to go.

@martindurant
Copy link
Member

I think that's fine.

@martindurant martindurant merged commit 4f5b9fb into fsspec:main Oct 20, 2023
5 checks passed
@maxrjones maxrjones deleted the use-pyproject-toml branch October 20, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants