Use the block size determined by asyncssh if nothing is specified #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxmlnkn
force-pushed
the
use-larger-blocks
branch
from
80f3285
to
f8443c3
Compare
shcheklein
reviewed
Oct 3, 2024
|
|
||
| self.kwargs = kwargs | ||
|
|
||
| self._file = sync(self.loop, self._open_file) | ||
| self._closed = False | ||
|
|
||
| def _determine_block_size(self, channel): |
There was a problem hiding this comment.
should it be cached? should it be async?
shcheklein
reviewed
Oct 3, 2024
| @@ -81,6 +90,9 @@ async def _open_file(self): | |||
| def readable(self): | |||
| return "r" in self.mode | |||
|
|
|||
| def seekable(self): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49
Note that the
limitsproperty will be added with this commit, which has not been released yet. It would be prudent to wait for this API to stabilize with the next version release of asyncssh.This implementation checks for the existence of this property anyway, so that it also works with older versions of asyncssh.
I also need to check how it should behave / behaves with a server not supporting the limits query. Probably simply check
max_read_lenfor None.