-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some minor changes #1
Conversation
Hi, thanks for the interest, glad it's useful to someone :D
|
|
@joostruis if you want to submit the small changes we discussed above, I can merge this PR and we can move this forward =) For 2) we can drop it as per your PR, worst case we re-add it later if it breaks anything. |
To me it is unclear what small changes I should make. I am uncertain about geoclue. I do believe I had it installed on the system while I was test running. I am 100% sure it isn't required at build time. |
Ah sorry, I went commit-by-commit, and remember seeing the greeter (and perhaps something else) becoming optional and not seeing it removed. I think it's all fine, actually, sorry for the confusion. Merging. |
Hey there! Thanks for your work on this, it seems pretty good so far.
I made some (minimal) changes I required to build it against Gentoo stable tree and package it for MocaccinoOS.
Please note that once the alpha release gets tagged you require rust 1.79.0 ( see pop-os/xdg-desktop-portal-cosmic#55 (comment) )
Still not sure about acct-group/cosmic-greeter and acct-user/cosmic-greeter I prefer setting a static UID and a GUI like all other entities in Portage do.