Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor changes #1

Merged
merged 10 commits into from
Jul 23, 2024
Merged

Some minor changes #1

merged 10 commits into from
Jul 23, 2024

Conversation

joostruis
Copy link
Contributor

Hey there! Thanks for your work on this, it seems pretty good so far.

I made some (minimal) changes I required to build it against Gentoo stable tree and package it for MocaccinoOS.

  • I made store optional by use flag in the cosmic-meta package
  • Removed geoclue as a hard dep. You do not require this at all I believe
  • Use stable sci-libs/libqalculate
  • Made cosmic-de/pop-gtk-theme optional by use flag

Please note that once the alpha release gets tagged you require rust 1.79.0 ( see pop-os/xdg-desktop-portal-cosmic#55 (comment) )

Still not sure about acct-group/cosmic-greeter and acct-user/cosmic-greeter I prefer setting a static UID and a GUI like all other entities in Portage do.

@fsvm88
Copy link
Owner

fsvm88 commented Jul 12, 2024

Hi, thanks for the interest, glad it's useful to someone :D

  1. No problems with the optional package changes, do you think we should/could make them recommended by default? (+IUSE) I'd like to provide a functional-by-default environment for the casual user. Perhaps the store could remain optional.
  2. For geoclue, I remember thinking of dropping that myself, however there's an open issue for that at the moment, I recall adding it because of it: Make geoclue optional pop-os/cosmic-settings-daemon#14
  3. Agree on libqalculate (I hoped 5.x would have hit stable by now)
  4. I can bump to rust >=1.79 after we merge this PR (which breaks a bit the "stable tree" changes here), thanks for the heads up!
  5. I went with auto-determined UID and GID because fixed ones are assigned in tree, and didn't want to risk conflicting with other packages. If this overlay ever gets merged to the main tree, that's a totally valid change that would need to be applied.

@joostruis
Copy link
Contributor Author

  1. yes. -store for certain I think.
  2. I've been using epoch git for a while on a system where there is no geoclue and neither at compile time and never noticed a problem (or never knew there could be a problem with this to be honest)
  3. ok
  4. no problemo
  5. reasonable thought indeed.

@fsvm88
Copy link
Owner

fsvm88 commented Jul 23, 2024

@joostruis if you want to submit the small changes we discussed above, I can merge this PR and we can move this forward =)

For 2) we can drop it as per your PR, worst case we re-add it later if it breaks anything.

@joostruis
Copy link
Contributor Author

To me it is unclear what small changes I should make. I am uncertain about geoclue. I do believe I had it installed on the system while I was test running. I am 100% sure it isn't required at build time.

@fsvm88
Copy link
Owner

fsvm88 commented Jul 23, 2024

Ah sorry, I went commit-by-commit, and remember seeing the greeter (and perhaps something else) becoming optional and not seeing it removed.

I think it's all fine, actually, sorry for the confusion.

Merging.

@fsvm88 fsvm88 merged commit a86307f into fsvm88:main Jul 23, 2024
joostruis added a commit to mocaccinoOS/desktop that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants