Put JS through build pipeline #285
Conversation
|
fixes #286 |
| @@ -1,4 +1,7 @@ | |||
| @import 'o-grid/main'; | |||
| @import 'o-fonts/main'; | |||
|
|
|||
| @include oFontsInclude(MetricWeb, medium); | |||
There was a problem hiding this comment.
Don't. We don't need every font. I'll change the font weight CSS instead
There was a problem hiding this comment.
We do need this font. It's used all over the place. The Semibold is only used in one place, we should remove that if we need to remove one.
There was a problem hiding this comment.
Things should be changed to semi bold. I you remember, this change happen during the run up to Brexit too. We've limited the font set to keep it as close as possible to the rest of the site.
| @@ -10,7 +10,7 @@ | |||
| ] | |||
| %} | |||
| {% set scripts = [ | |||
| 'main.js', | |||
| 'main.entry.js', | |||
There was a problem hiding this comment.
The browserify default is for *.entry.js to be treated as an entry. I could rename the file back to main.js and just configure browserify to treat main.js as an entry instead, if you prefer
| const port = server.address().port; | ||
| console.log(`running ${host} ${port}`); | ||
| console.log(`running http://localhost:${port}/`); |
There was a problem hiding this comment.
What about prod. That's not local host.
| @@ -100,7 +98,7 @@ app.get('/__access_metadata', (req, res) => { | |||
| res.setHeader('Content-Type', 'application/json'); | |||
| res.setHeader('Cache-Control', `public, max-age=86400`); | |||
| res.send(` | |||
| {"access_metadata":[{"path_regex":"\/us-elections*","classification":"unconditional"}, | |||
| {"access_metadata":[{"path_regex":"/us-elections*","classification":"unconditional"}, | |||
There was a problem hiding this comment.
The slash is needed. Do not merge this!!!
There was a problem hiding this comment.
Ah the linter complained about it as unnecessary
There was a problem hiding this comment.
If that backslash is supposed to be in the output, it should be \\.
\\/translates to\/\/translates to//translates to/
which do we want
There was a problem hiding this comment.
👍 ok, just needed to also check the access service docs
No description provided.