Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Simplify expected_to/might logic #7

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jgigault
Copy link
Collaborator

No description provided.

@jgigault
Copy link
Collaborator Author

@gabkk @ftwftw0 @drnvl
Hello
Je propose de simplifier la logique des "verbes" :

Au lieu d'avoir deux versions pour chaque verbe (have_regexp et have_not_regexp ou be_empty et be_filled par exemple) qui génère beaucoup de duplication de code, ajoutons plutôt deux nouveaux mots clés expected_to_not et might_not qui inversent simplement le résultat des verbes affirmatifs comme have_regexp et be_empty.

expected_to be_filled
#devient 
expected_to_not be_empty

expected_to have_not_regexp "..."
#devient
expected_to_not have_regexp "..."

#etc...

Qu'en pensez-vous ?

J'ai fait un exemple dans ce commit

@jgigault jgigault changed the title Simplify expected_to/might logic [WIP] Simplify expected_to/might logic Mar 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant