Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add battlenet #136

Closed
wants to merge 0 commits into from
Closed

Add battlenet #136

wants to merge 0 commits into from

Conversation

kharf
Copy link

@kharf kharf commented Jan 1, 2024

Basically copied the star citizen config. Not sure about the GL settings, I think its for nvidia. I cant really test it as I am using AMD. I have been using this setup for a couple of days now and it works flawlessly.

@kharf
Copy link
Author

kharf commented Jan 1, 2024

just saw that my commit doesn`t adhere to the common style. Should I amend it?

@NotAShelf
Copy link
Contributor

you can reword in git rebase interactive

@kharf
Copy link
Author

kharf commented Jan 1, 2024

you can reword in git rebase interactive

yea thats basically the same. Will do so

@kharf kharf changed the title feat: add battlenet Add battlenet Jan 1, 2024
@kharf kharf marked this pull request as draft January 2, 2024 06:13
pkgs,
}: let
src = pkgs.fetchurl rec {
url = "https://www.battle.net/download/getInstallerForGame?os=win&version=LIVE&gameProgram=BATTLENET_APP";
Copy link
Author

@kharf kharf Jan 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still figuring out how to get this reproducible ... havent found a versioned link. The version path param seems to accept everything

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fufexan do you know if there is a recommended or common way to approach this?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't. I've looked in the lutris Battle.net script and it's the same URL. If it's not deterministic on their end, there's not much we can do. Maybe there are some other parameters that we don't know about.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just searched for the versions and this URL seems to yield deterministic results, but we'll have to update it periodically in some way.
https://downloader.battle.net/download/getInstallerForGame?os=win&gameProgram=BATTLENET_APP&version=2.26.0.14494

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can see, we can use https://blizztrack.com/swagger/index.html in an update script, but I don't have time to fiddle with it right now.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ill see what I can do, thank you. Probably will take some time, because of minimal free time

@kharf kharf closed this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants