-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add battlenet #136
Add battlenet #136
Conversation
just saw that my commit doesn`t adhere to the common style. Should I amend it? |
you can |
yea thats basically the same. Will do so |
pkgs/battlenet/default.nix
Outdated
pkgs, | ||
}: let | ||
src = pkgs.fetchurl rec { | ||
url = "https://www.battle.net/download/getInstallerForGame?os=win&version=LIVE&gameProgram=BATTLENET_APP"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still figuring out how to get this reproducible ... havent found a versioned link. The version path param seems to accept everything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fufexan do you know if there is a recommended or common way to approach this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't. I've looked in the lutris Battle.net script and it's the same URL. If it's not deterministic on their end, there's not much we can do. Maybe there are some other parameters that we don't know about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just searched for the versions and this URL seems to yield deterministic results, but we'll have to update it periodically in some way.
https://downloader.battle.net/download/getInstallerForGame?os=win&gameProgram=BATTLENET_APP&version=2.26.0.14494
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can see, we can use https://blizztrack.com/swagger/index.html in an update script, but I don't have time to fiddle with it right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ill see what I can do, thank you. Probably will take some time, because of minimal free time
Basically copied the star citizen config. Not sure about the GL settings, I think its for nvidia. I cant really test it as I am using AMD. I have been using this setup for a couple of days now and it works flawlessly.