Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Clint Valentine <[email protected]>
  • Loading branch information
nh13 and clintval authored Aug 16, 2023
1 parent afa97e6 commit 279dfcf
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion src/main/scala/com/fulcrumgenomics/fastq/TrimFastq.scala
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ class TrimFastq
val progress = new ProgressLogger(this.logger, noun="records", verb="Wrote")

val lengths = if (this.length.size == 1) List.fill(this.input.size)(this.length.head) else this.length

val sources = input.map(FastqSource(_))
val writers = output.map(FastqWriter(_))
while (allHaveNext(sources)) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ class TrimFastqTest extends UnitSpec {
r2Map("20x20").length shouldBe 15
}

it should "trim some reads and discard others with FASTQ specific lengths" in {
it should "trim each FASTQ independently to a FASTQ-specific length" in {
val (r1, r2) = fqFiles
val (r1Out, r2Out) = (makeTempFile("r1out.", ".fq"), makeTempFile("r2out.", ".fq"))
new TrimFastq(input = Seq(r1, r2), output=Seq(r1Out, r2Out), length = Seq(10, 15), exclude = false).execute()
Expand Down

0 comments on commit 279dfcf

Please sign in to comment.