Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow TrimFastq to specify a length per input FASTQ #928

Merged
merged 3 commits into from
Aug 16, 2023
Merged

feat: allow TrimFastq to specify a length per input FASTQ #928

merged 3 commits into from
Aug 16, 2023

Conversation

nh13
Copy link
Member

@nh13 nh13 commented Aug 16, 2023

See: #927

clintval
clintval approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@clintval clintval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve conditional on fixing up a test name!

src/test/scala/com/fulcrumgenomics/fastq/TrimFastqTest.scala Outdated Show resolved Hide resolved
@nh13 nh13 merged commit 8d40e74 into main Aug 16, 2023
4 checks passed
@nh13 nh13 deleted the feat/trim-fastq-multiple-trim-length branch August 16, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clintval clintval clintval approved these changes

Assignees

@nh13 nh13

Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nh13 @clintval