bugfix: ZipperBams should consume any remaining mapped reads #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that pipes do not cause failure when unread data exists in bash strict mode
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #929 +/- ##
==========================================
- Coverage 95.61% 95.60% -0.02%
==========================================
Files 126 126
Lines 7303 7305 +2
Branches 498 517 +19
==========================================
+ Hits 6983 6984 +1
- Misses 320 321 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
nh13
commented
Aug 18, 2023
tfenne
approved these changes
Aug 18, 2023
tfenne
reviewed
Aug 18, 2023
| |order, and reads with the same name are consecutive (grouped) in each input""".stripMargin | ||
| ) | ||
| } | ||
|
|
||
| out.close() |
There was a problem hiding this comment.
It would probably be kind to move out.close() above so that the output BAM is at least somewhat valid/intact?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that pipes do not cause failure when unread data exists in bash strict mode.
@jacarey