Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZipperBams to produce mate score ("ms") for samtools markdup #952

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

nh13
Copy link
Member

@nh13 nh13 commented Dec 18, 2023

Fixes: #951

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c475fd) 95.62% compared to head (87e8288) 95.62%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #952    +/-   ##
========================================
  Coverage   95.62%   95.62%            
========================================
  Files         126      126            
  Lines        7354     7454   +100     
  Branches      502      491    -11     
========================================
+ Hits         7032     7128    +96     
- Misses        322      326     +4     
Flag Coverage Δ
unittests 95.62% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nh13 nh13 marked this pull request as ready for review December 19, 2023 22:14
Copy link
Member

@tfenne tfenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't object in principal, but these should all probably be of the form:

primary.get[Int]("AS").foreach(supp("ms") = _)

so that it will work for aligners that don't produce an AS tag and on pairs where only one read is aligned.

@nh13 nh13 requested a review from tfenne December 28, 2023 01:08
Copy link
Member

@tfenne tfenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but could you add/amend a couple of tests to make sure it works on both reads that have and don't have AS set?

Copy link

@TedBrookings TedBrookings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Looks good to me

@nh13 nh13 merged commit 3a74fd2 into main Feb 9, 2024
6 checks passed
@nh13 nh13 deleted the nh13-patch-1 branch February 9, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZipperBams should output the ms tag for samtools markdup
3 participants