Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codecov not finding the secret token #982

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

nh13
Copy link
Member

@nh13 nh13 commented Apr 25, 2024

No description provided.

@nh13 nh13 changed the base branch from main to cv_fixup_fr_filter April 25, 2024 19:10
@nh13 nh13 changed the title Nh codecov fixup Fix codecov not finding the secret token Apr 25, 2024
@nh13 nh13 marked this pull request as ready for review April 25, 2024 19:10
@nh13 nh13 requested a review from clintval April 25, 2024 19:10
@clintval clintval merged commit c02e0b3 into cv_fixup_fr_filter Apr 25, 2024
4 checks passed
@clintval clintval deleted the nh_codecov_fixup branch April 25, 2024 19:11
clintval added a commit that referenced this pull request Apr 25, 2024
…orrect (#981)

* Make PileupBuilder.includeMapPositionsOutsideFrInsert intuitively correct

* Revert back to the original isFrPair filtering logic and document better

* chore: update test name

* fix: codecov try specifying the environment (#982)

---------

Co-authored-by: Nils Homer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants