fix: Executable path validation tests should not be dependent on the user environment #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msto
commented
Sep 18, 2024
msto
commented
Sep 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
=======================================
Coverage 97.37% 97.37%
=======================================
Files 25 25
Lines 1597 1597
Branches 302 302
=======================================
Hits 1555 1555
Misses 23 23
Partials 19 19 ☔ View full report in Codecov by Sentry. |
|
@geoffjentry Could you review this one instead of me please? |
geoffjentry
approved these changes
Sep 18, 2024
msto
force-pushed
the
ms_fix-executable-tests
branch
from
27caf18 to
122cb80
Compare
msto
commented
Sep 19, 2024
msto
force-pushed
the
ms_fix-executable-tests
branch
from
dc54e6f to
3348b7c
Compare
geoffjentry
approved these changes
Sep 19, 2024
tfenne
approved these changes
Sep 19, 2024
msto
force-pushed
the
ms_fix-executable-tests
branch
from
3348b7c to
5062706
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20
Homebrew installation of the GNU coreutils caused a conflict with expectation in the
ExecutableRunnervalidation tests.Tests were updated to clear the
PATHbefore executing.