review fixup

fg-stitch-lib/src/align/aligners/mod.rs

@@ -726,20 +726,20 @@ impl<'a, F: MatchFunc> SamRecordFormatter<'a, F> {
                 let min_score =
                     primary_alignment_score as f32 * self.opts.filter_secondary_pct / 100.0;
 
-                let mut new_subs = Vec::new();
-                let mut old_idx = 0;
-                while !subs.is_empty() {
-                    let sub = subs.remove(0);
-                    // Update the index of the primary sub-alignment, as we may have removed
-                    // sub-alignments ahead of it
-                    if old_idx == primary_sub_idx {
-                        primary_sub_idx = new_subs.len();
-                    }
-                    if sub.score as f32 >= min_score {
-                        new_subs.push(sub);
-                    }
-                    old_idx += 1;
-                }
+                // Filter out sub-alignments that have score worse than X% of the primary
+                let subs_len = subs.len();
+                let (new_subs, _) = subs.into_iter().fold(
+                    (Vec::with_capacity(subs_len), 0),
+                    |(mut new_subs, old_idx), sub| {
+                        if old_idx == primary_sub_idx {
+                            primary_sub_idx = new_subs.len();
+                        }
+                        if sub.score as f32 >= min_score {
+                            new_subs.push(sub);
+                        }
+                        (new_subs, old_idx + 1)
+                    },
+                );
                 subs = new_subs;
             }