Upper-case query sequences #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing due to Clippy issues. I'll create a separate issue for that and fix them. |
jdidion
changed the title
jdidion
changed the title
jdidion
force-pushed
the
bug-25-case-insensitive
branch
from
1a37cab
to
da0f07a
Compare
jdidion
force-pushed
the
bug-25-case-insensitive
branch
from
da0f07a
to
e96d9c2
Compare
nh13
reviewed
Sep 7, 2023
|
|
||
| #[test] | ||
| fn test_case_insensitive() { | ||
| // HACK: creating an `Aligners` should not require parsing command line arguments |
nh13
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #25: query sequences are converted to upper-case as they are processed.
The unit test uses (what I consider) a hack to build the
Argsobject to pass tobuild_aligners. This should be addressed in a future refactoring.I also got rid of an unnecessary allocation I noticed.