Add enum class for custom tags, implement conversion to Tag #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nh13
approved these changes
Sep 19, 2023
|
@nh13 am I allowed to merge this into your branch, or should I let you do that? |
nh13
pushed a commit
that referenced
this pull request
Sep 19, 2023
nh13
pushed a commit
that referenced
this pull request
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benefits:
usea bunch of constants (although you could dotag::CHAIN_ALIGNMENT_SCORE, etc. instead)Tag::Otherconstinitializer is implemented, you only need to change the implementation ofFrom- public API stays the same.Drawbacks:
In any case, you'll get a minor performance bump from converting from bytes rather than strings.