Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NM tag properly calculated for chains #61

Merged
merged 2 commits into from
Sep 20, 2023
Merged

fix: NM tag properly calculated for chains #61

merged 2 commits into from
Sep 20, 2023

Conversation

nh13
Copy link
Member

@nh13 nh13 commented Sep 20, 2023

Reset num_endits in align::sub_alignment

Fixes #60

Reset num_endits in align::sub_alignment

Fixes #60
@jdidion
Copy link
Collaborator

jdidion commented Sep 20, 2023

@nh13 you also need to change self to a ~line 233 (when swapping).

@nh13 nh13 requested a review from jdidion September 20, 2023 19:56
@nh13 nh13 marked this pull request as ready for review September 20, 2023 19:56
@nh13
Copy link
Member Author

nh13 commented Sep 20, 2023

The past few bugs are providing the appropriate feelings of shame for rushing and not writing unit tests (not that we had great coverage to begin). My apologies.

@nh13 nh13 merged commit 5942203 into main Sep 20, 2023
4 checks passed
@nh13 nh13 deleted the nh-fix-60 branch September 20, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NM is the same for all reads in a chain
2 participants