Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved from suds-jurko to suds-community for ongoing support and versions #31

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Moved from suds-jurko to suds-community for ongoing support and versions #31

wants to merge 1 commit into from

Conversation

TinBane
Copy link

@TinBane TinBane commented Sep 27, 2021

Description of the change

Switched suds-jurko to suds-community

Type of change

  • [ X] Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@TinBane TinBane mentioned this pull request Sep 27, 2021
Open
@lchritik
Copy link

Can we please get this merged ?

louiepopp
louiepopp approved these changes Aug 29, 2022
View reviewed changes
Copy link

@louiepopp louiepopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with over half of the endpoints.

@john-herholz-dt
Copy link

Can we get this merged, please? @louiepopp what is blocking this? Who is merging this?

john-herholz-dt
john-herholz-dt approved these changes Apr 13, 2023
View reviewed changes
Copy link

@john-herholz-dt john-herholz-dt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louiepopp louiepopp louiepopp approved these changes

@tmewes tmewes tmewes approved these changes

@gabit-ch gabit-ch gabit-ch approved these changes

@john-herholz-dt john-herholz-dt john-herholz-dt approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setuptools v 58 or higher breaks suds-jurko, the correct fix is to switch to community suds
6 participants
@TinBane @lchritik @john-herholz-dt @louiepopp @tmewes @gabit-ch