Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encountered issues with asyncIterator, found suggestions for and successfully implemented asyncIterableIterator #3985

Open
wants to merge 5 commits into
base: source
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/content/8/en/part8e.md
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,7 @@ const resolvers = {
// highlight-start
Subscription: {
personAdded: {
subscribe: () => pubsub.asyncIterator('PERSON_ADDED')
subscribe: () => pubsub.asyncIterableIterator('PERSON_ADDED')
},
},
// highlight-end
Expand All @@ -610,7 +610,7 @@ There are only a few lines of code added, but quite a lot is happening under the
```js
Subscription: {
personAdded: {
subscribe: () => pubsub.asyncIterator('PERSON_ADDED')
subscribe: () => pubsub.asyncIterableIterator('PERSON_ADDED')
},
},
```
Expand Down
2 changes: 1 addition & 1 deletion src/content/8/es/part8e.md
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ const pubsub = new PubSub() // highlight-line
// highlight-start
Subscription: {
personAdded: {
subscribe: () => pubsub.asyncIterator(['PERSON_ADDED'])
subscribe: () => pubsub.asyncIterableIterator(['PERSON_ADDED'])
},
},
// highlight-end
Expand Down
4 changes: 2 additions & 2 deletions src/content/8/fi/osa8e.md
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,7 @@ const resolvers = {
// highlight-start
Subscription: {
personAdded: {
subscribe: () => pubsub.asyncIterator('PERSON_ADDED')
subscribe: () => pubsub.asyncIterableIterator('PERSON_ADDED')
},
},
// highlight-end
Expand All @@ -608,7 +608,7 @@ Koodia on vähän mutta konepellin alla tapahtuu paljon. Tilauksen _personAdded_
```js
Subscription: {
personAdded: {
subscribe: () => pubsub.asyncIterator('PERSON_ADDED')
subscribe: () => pubsub.asyncIterableIterator('PERSON_ADDED')
},
},
```
Expand Down
2 changes: 1 addition & 1 deletion src/content/8/zh/part8e.md
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@ const pubsub = new PubSub() // highlight-line
// highlight-start
Subscription: {
personAdded: {
subscribe: () => pubsub.asyncIterator(['PERSON_ADDED'])
subscribe: () => pubsub.asyncIterableIterator(['PERSON_ADDED'])
},
},
// highlight-end
Expand Down