Add better helper for unwrapping exceptions

funcool · Jan 16, 2024 · 60d3f16 · 60d3f16
1 parent 484b7f5
commit 60d3f16
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -23,6 +23,7 @@ BREAKING CHANGES:
   never have been there.
 
 
+
 ## Version 11.0.678
 
 - Fix internal coercion function (cljs only) that causes unexpected

diff --git a/src/promesa/util.cljc b/src/promesa/util.cljc
@@ -67,24 +67,25 @@
      (instance? TimeoutException e)))
 
 #?(:clj
-   (defn unwrap-completion-exception
-     {:no-doc true}
+   (defn unwrap-exception
+     "Unwrap CompletionException or ExecutionException"
      [cause]
-     (if (instance? CompletionException cause)
-       (.getCause ^CompletionException cause)
+     (if (or (instance? CompletionException cause)
+             (instance? ExecutionException cause))
+       (or (ex-cause cause) cause)
        cause)))
 
 #?(:clj
    (deftype Function2 [f]
      java.util.function.BiFunction
      (apply [_ r e]
-       (f r (unwrap-completion-exception e)))))
+       (f r (unwrap-exception e)))))
 
 #?(:clj
    (deftype Consumer2 [f]
      java.util.function.BiConsumer
      (accept [_ r e]
-       (f r (unwrap-completion-exception e)))))
+       (f r (unwrap-exception e)))))
 
 (defn handler
   "Create a handler, mainly for combine two separate functions