TSOMPlusSOMにtransform関数を追加 #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
テスト通ったスクショ |
|
#107 がマージされた後にマージして欲しいやつですねこれ |
…06_add_transform_tsom_plus_som
|
#109 の変更をマージした。これでTSOMPlusSOMでもtransformが作れる。 |
|
というか既に作っていた。som待ちだった。 |
|
kernel_widthはやっぱりinitで持たせてselfにしたいなぁ… |
|
テスト通った |
|
@takuro-Ishida @senoura |
|
あ、 #110 の内容をマージしてるので、そっちがマージされた後でマージしたいなと思ってます！ |
|
|
|
Approveします |
ae14watanabe
requested review from
takuro-Ishida
and removed request for
senoura
|
誰にレビュワーお願いしようかな…💦 |
takuro-Ishida
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 説明
close #106
** Type of change 変更の種類**
How Has This Been Tested? どのようにテストしたか？
testコードでfit内の勝者決定とtransform内の勝者決定の結果が一致するか確認するメソッドを作成しpassを確認した。
reviewerに確認して欲しいこと
テストのメソッドの内容を確認し、passを確認して欲しいです！