Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace const keyword with var #11

Merged
merged 1 commit into from
Oct 13, 2017
Merged

Conversation

jmgirven
Copy link
Contributor

Old browsers don't support const. Replaced it with var instead.

Old browsers don't support const.
@fusepilot
Copy link
Owner

Hi Jonathan,

As far as I know, all versions of CEP support const. Are you running into an issue where this is throwing an error?

@jmgirven
Copy link
Contributor Author

My plugin works in both a CEP environment and from a browser. I use inCEPEnvironment from this package to detect whether to enable CEP specific features. Therefore I come across more varied environments than you probably have. It wouldn't be difficult for me to change to a different system, but it also seemed easy enough to remove the usages of const. Up to you.

@fusepilot fusepilot merged commit 1c029ee into fusepilot:master Oct 13, 2017
@fusepilot
Copy link
Owner

Fair enough, thanks!

@jmgirven jmgirven deleted the patch-1 branch October 16, 2017 14:33
@jmgirven
Copy link
Contributor Author

Thanks. Do you have a plan for updating npm in the not too distant future?

@fusepilot
Copy link
Owner

fusepilot commented Oct 16, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants