This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
[Subnet] add try catch in delete subnet for subnet routing rule deletion if routing table is not exist #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cj-chung
changed the title
xieus
reviewed
Jul 2, 2021
| @@ -537,7 +539,11 @@ public ResponseId deleteSubnetState(@PathVariable String projectId, @PathVariabl | |||
| } | |||
|
|
|||
| // delete subnet routing rule in route manager | |||
| this.subnetService.deleteSubnetRoutingRuleInRM(projectId, subnetId); | |||
| try { | |||
| this.subnetService.deleteSubnetRoutingRuleInRM(projectId, subnetId); | |||
There was a problem hiding this comment.
This method was to delete the entire routing table associated with this subnet in RM. Let us rename it to deleteSubnetRoutingTable.
|
@yanmo96 Could you update this PR? It has been a while. |
|
Will do, sorry miss the earlier comment. |
added try catch to 'delete subnet routing rule in route manager'
|
This is a workaround to fix Issue #660 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added try catch to 'delete subnet routing rule in route manager'.
From second part of issue #648