Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and cleanup #21

Merged
merged 17 commits into from
Jul 19, 2024
Merged

Simplify and cleanup #21

merged 17 commits into from
Jul 19, 2024

Conversation

fveracoechea
Copy link
Owner

@fveracoechea fveracoechea commented May 5, 2024

Description

  • Cleanup unnecessary helper functions.
  • Make function names more consistent.
  • Cleanup internals.
  • Fix size-limit check.
  • Update docs and readme.

Copy link

vercel bot commented May 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fetchtastic-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 2:36am

Copy link
Contributor

github-actions bot commented May 5, 2024

Coverage report for lib

St.
Category Percentage Covered / Total
🟢 Statements
89.05% (+4.34% 🔼)
179/201
🟢 Branches
80.49% (+5.22% 🔼)
66/82
🟢 Functions
83.93% (+6.51% 🔼)
47/56
🟢 Lines
90.63% (+4.91% 🔼)
174/192
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢 src/types.ts 100% 100% 100% 100%
🟢 src/Fetchtastic.ts 92.36% 84% 86.05% 94.16%
🟡 src/HttpError.ts 73.68% 53.85% 100% 77.78%
🟢 src/utility.ts 100% 100% 100% 100%
🟡 src/internals.ts 75% 86.67% 66.67% 75%

Test suite run success

33 tests passing in 7 suites.

Report generated by 🧪jest coverage report action from d4671c9

Copy link
Contributor

github-actions bot commented May 6, 2024

size-limit report 📦

Path Size
CommonJS 2.63 KB (-5.12% 🔽)
ES Modules 2.35 KB (-5.57% 🔽)

@fveracoechea fveracoechea marked this pull request as ready for review July 19, 2024 02:37
@fveracoechea fveracoechea merged commit 40c7a87 into main Jul 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant