Molving to preprocessify instead of remove lines since it's more vers… #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atile Also checking if we have performance.mark in order to not to fail in chrome
|
@lodr r? |
| @@ -26,19 +26,15 @@ gulp.task('bundle-dist', function() { | |||
| var bundler = browserify({ | |||
| entries: ['./index.js'], | |||
| debug: false, | |||
| standAlone: 'ServiceWorkerWare' | |||
| standAlone: 'ServiceWorkerWare', | |||
There was a problem hiding this comment.
Beware of that colon at the end of the line.
|
I like this preprocessor. It's a little bit verbose to enclose all with the directives and it would be great to have a special syntax for the directives to affect next line / block only. |
arcturus
added a commit
that referenced
this pull request
Oct 15, 2015
Molving to preprocessify instead of remove lines since it's more vers…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…atile
Also checking if we have performance.mark in order to not to fail in chrome