Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin using new APIs between Go 1.17 and 1.19 #4488

Merged
merged 22 commits into from
Jan 3, 2024

Conversation

Jacalz
Copy link
Member

@Jacalz Jacalz commented Dec 26, 2023

Description:

This implements the following changes:

  • Use the new safer and more convenient (as well as faster in the case of atomic.Pointer[]) atomic APIs in Go 1.19.
  • Stop using execabs and revert back to os/exec again.
  • Use the convenient strings.Cut() function instead of IndexByte and friends.
  • Use math.MaxInt instead of math.MaxInt32.
  • Update fredbi/uri to v1.1.0 for performance improvements.
  • Update x/image to v0.14.0 for various improvements.
  • Some dependencies are updated with newer go.mod versions for cleaned up go.sum file from more aggressive module graph pruning.
  • Added a generic version of the unbound channels that can replace code generation in the future (requires Go 1.21 for clear()).
  • The async queue no longer relies on the unsafe package.

For #3242

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • Any breaking changes have a deprecation path or have been discussed.

@coveralls
Copy link

coveralls commented Dec 26, 2023

Coverage Status

coverage: 64.577% (+0.2%) from 64.36%
when pulling 081664a on Jacalz:go-version-updates
into 78f2326 on fyne-io:develop.

@Jacalz Jacalz force-pushed the go-version-updates branch from f46806b to 049f4e4 Compare January 2, 2024 10:45
@Jacalz Jacalz marked this pull request as ready for review January 2, 2024 10:46
@Jacalz
Copy link
Member Author

Jacalz commented Jan 2, 2024

This PR became larger than what I was hoping for, partially because the GopherJS support removal PR took some time to get ready. Anyway, I think this should be quite simple to review either way. The changes aren't that huge and the commits can be looked at one by one if necessary.

@Jacalz Jacalz requested review from andydotxyz and changkun January 2, 2024 10:48
Copy link
Member

@changkun changkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the upgrades and all changes look good to me

Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Jacalz Jacalz merged commit 22386aa into fyne-io:develop Jan 3, 2024
11 checks passed
@Jacalz Jacalz deleted the go-version-updates branch January 3, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants