-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Begin using new APIs between Go 1.17 and 1.19 #4488
Conversation
b2c2152
to
f46806b
Compare
Requires Go 1.21 for the clear() builtin but will allow us to cut down on generation scripts later on.
f46806b
to
049f4e4
Compare
This PR became larger than what I was hoping for, partially because the GopherJS support removal PR took some time to get ready. Anyway, I think this should be quite simple to review either way. The changes aren't that huge and the commits can be looked at one by one if necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the upgrades and all changes look good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Description:
This implements the following changes:
atomic.Pointer[]
) atomic APIs in Go 1.19.execabs
and revert back toos/exec
again.strings.Cut()
function instead of IndexByte and friends.math.MaxInt
instead ofmath.MaxInt32
.fredbi/uri
to v1.1.0 for performance improvements.x/image
to v0.14.0 for various improvements.go.mod
versions for cleaned upgo.sum
file from more aggressive module graph pruning.clear()
).unsafe
package.For #3242
Checklist:
Where applicable: