Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Update the list of Kazakhstan regions and cities. #1849

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update the list of Kazakhstan regions and cities. #1849

wants to merge 1 commit into from

Conversation

@pimjansen
Copy link
Contributor

Please see #1851

@crayxt
Copy link
Author

crayxt commented Nov 22, 2019

@pimjansen I see. I would categorize this PR as bugfix then, since I fixed the outdated information.

@pimjansen
Copy link
Contributor

@crayxt i dont agree here since we are actually just changing a recordset. We generate dummy data meaning that outdated data is not directly wrong. It is maybe not for your needs though.

So i would like to ask to please join the discussion Faker 2 so we can get it going asap and also have a full new Kazakhstan locale at some point

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants