This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Update optional() in readme to use v2 weight #2068
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2068 +/- ##
============================================
- Coverage 56.56% 56.30% -0.27%
Complexity 2068 2068
============================================
Files 306 306
Lines 4849 4849
============================================
- Hits 2743 2730 -13
- Misses 2106 2119 +13
Continue to review full report at Codecov.
|
|
I dont really see an actual usecase for this where the float is valid as well? |
|
I assume it's still there for backwards compatibility. This PR doesn't change functionality. It only updates the README based on the new system. Maybe I can open a separate PR for Faker v2 because it would be a breaking change? It would basically take care of the TODO in the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documentation for
optional()to use the new weight system (percent 0 to 100 instead of float 0 to 1).optional()source code🙏 Possible to add
hacktoberfest-acceptedlabel to this PR? (Details)