This repository has been archived by the owner on Mar 22, 2018. It is now read-only.
allow options specified in yaml to be passed to phantomjs #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something i had done to support our use case (which is to pass --ssl-protocol=tlsv1).
i see that this basic need is referenced by both: #66 and #31, of the two, @slorber 's use of yaml list is more versatile.
I have not updated the default yaml as that's a per project decision, and i don't want to go changing other people's default behavior. eg. don't use =any, we use tlsv1
At any rate. this issue needing fixing for us, and i see others have fixed it in various ways without getting merged. Hopefully a very isolated change that doesn't affect default behavior will make the cut..