Issue #116: Pull Request for heartbeat into 1.1 #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created the heartbeat endpoint spec.
fschiettecatte
changed the title
|
Should we mention that: Just to make those who are not primarily developers aware. |
Added response code section as per @Relequestual request.
|
@Relequestual - sure, and done. |
DECIPHER will return content on an offline 500 response for example.
Relequestual
approved these changes
Aug 7, 2017
sdumitriu
reviewed
Aug 8, 2017
| | HTTP Status Code | Reason Phrase | Description | ||
| | ---------------- | -------- | ----------- | ||
| | 200 | OK | no error | | ||
| | 401 | Unauthorized | invalid API key |
There was a problem hiding this comment.
Is this a protected resource? If yes, should the authentication header be documented as well, or at least link to another place where this is documented. If not, then this status code seems misplaced.
Added reference to API Key
Added reference to API Key
sdumitriu
approved these changes
Aug 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for heartbeat into 1.1 - issue #116