Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #113: Strongly recommend ensembl gene ID in 1.1 #143

Merged
merged 2 commits into from
Sep 1, 2017
Merged

Issue #113: Strongly recommend ensembl gene ID in 1.1 #143

merged 2 commits into from
Sep 1, 2017

Conversation

fschiettecatte
Copy link
Contributor

@fschiettecatte fschiettecatte commented Aug 5, 2017 •
edited
Loading

Adding language to strongly recommend the use of ensembl gene ID in 1.1, see issue #113

@fschiettecatte fschiettecatte changed the title Issue 113 - strongly recommend ensembl gene ID trongly recommend ensembl gene ID - Issue #113 Aug 5, 2017
@fschiettecatte fschiettecatte changed the title trongly recommend ensembl gene ID - Issue #113 Strongly recommend ensembl gene ID - Issue #113 Aug 5, 2017
@fschiettecatte fschiettecatte changed the title Strongly recommend ensembl gene ID - Issue #113 Strongly recommend ensembl gene ID Aug 5, 2017
@fschiettecatte fschiettecatte changed the title Strongly recommend ensembl gene ID Strongly recommend ensembl gene ID in 1.1 Aug 5, 2017
@fschiettecatte fschiettecatte changed the title Strongly recommend ensembl gene ID in 1.1 Issue #113 - Strongly recommend ensembl gene ID in 1.1 Aug 5, 2017
@fschiettecatte fschiettecatte changed the title Issue #113 - Strongly recommend ensembl gene ID in 1.1 Issue #113: Strongly recommend ensembl gene ID in 1.1 Aug 5, 2017
@fschiettecatte fschiettecatte modified the milestone: v1.1 Aug 5, 2017
@sdumitriu
Copy link
Member

Too many commits in this branch. Can you clean it up?

@Relequestual Relequestual changed the base branch from master to release/v1.1 August 7, 2017 08:18
@Relequestual
Copy link
Member

@sdumitriu Less now. Merge target was master and should have been releas 1.1.

sdumitriu
sdumitriu requested changes Aug 8, 2017
View reviewed changes
Copy link
Member

@sdumitriu sdumitriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another place to change: the example JSON, line 69.

@Relequestual
Copy link
Member

@sdumitriu OK to approve this now?

@fschiettecatte fschiettecatte merged commit c06aefd into release/v1.1 Sep 1, 2017
@fschiettecatte fschiettecatte deleted the issue-113 branch September 1, 2017 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdumitriu sdumitriu sdumitriu approved these changes

@Relequestual Relequestual Relequestual approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@fschiettecatte @sdumitriu @Relequestual