Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

current rule structure. with new class design #340

Merged
merged 2 commits into from
Jan 22, 2021
Merged

Conversation

gagoar
Copy link
Owner

@gagoar gagoar commented Jan 18, 2021

Issue Reference: progress on #213

Description

This PR changes the point of contact between every part of the system and the rules.

Motivation and Context

I've unified the Rules interactions with the system into 2 classes. that will serve us as a simplified API.

Rules and MatchingRules will allow us to work on them to bring the new rules structures in place without creating confusion or changing (much) actions and the index while we rework things.

How Has This Been Tested?

unit tests.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Jan 18, 2021

Codecov Report

Merging #340 (96acace) into master (866bb44) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #340   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          338       349   +11     
  Branches        44        61   +17     
=========================================
+ Hits           338       349   +11     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)
src/rules.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 866bb44...96acace. Read the comment docs.

@gagoar gagoar force-pushed the gg/new_rules_structure branch from 86a1001 to 96acace Compare January 21, 2021 07:04
@gagoar gagoar merged commit 13a175e into master Jan 22, 2021
@gagoar gagoar deleted the gg/new_rules_structure branch January 22, 2021 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants