BDRSPS-1117: Move registries out of the classes they register #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also refactor get_mappers to registered_ids so there is less chance of registry being mutated where it shouldn't
These methods return Type[FlexibleVocabulary], rather than Type[Vocabulary] This lets us move the __init__ arguments to the FlexibleVocab class, and so code that is using regular, restricted vocabs, doesn't need to supply those args when instantiating the vocab.
Lincoln-GR
changed the title
chungvl
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 commits can be viewed individually:
get_flexible_vocabfunction and method, and use them where appropriate.