fix: handle typedPackageImport

src/rules/requireExtension.ts

@@ -186,19 +186,13 @@ const handleAliasPath = (
     return true;
   }
 
-  const moduleRoot = findDirectory(resolvedImportPath, 'package.json', '/')
-    // This is a workaround for resolveImport resolving to @types/ of the package.
-    // This is going to fail if the actual package is not in the parent directory.
-    ?.replace('/@types/', '/');
+  const moduleRoot = findDirectory(resolvedImportPath, 'package.json', '/');
 
-  // This would be an import from node_modules or a linked package.
   if (moduleRoot) {
-    const moduleName = readPackageJson(
-      resolve(moduleRoot, 'package.json'),
-    ).name;
+    const tail = moduleRoot.split('/node_modules/').pop();
 
-    if (importPath === moduleName) {
-      return true;
+    if (tail === importPath || tail === '@types/' + importPath) {
+      return false;
     }
   }
 

tests/fixtures/requireExtension/packageTypesImport/subject.ts

@@ -1,2 +1,3 @@
 // Note that this resolves to @types/chance, which is a TypeScript declaration file.
+// Compare this test to the "typedPackageImport" test which imports a typed dependency.
 import { Chance } from 'chance';

tests/fixtures/requireExtension/typedPackageImport/subject.ts

@@ -0,0 +1,3 @@
+// Note that this resolves to roarr, which is a package with TypeScript types.
+// Compare this test to the "packageTypesImport" test which imports dependency's types.
+import { Roarr } from 'roarr';

tests/fixtures/requireExtension/typedPackageImport/tsconfig.json

@@ -0,0 +1,8 @@
+{
+  "compilerOptions": {
+    "baseUrl": "."
+  },
+  "include": [
+    "."
+  ]
+}

tests/rules/requireExtension.ts

@@ -78,6 +78,7 @@ ruleTester.run('require-extension', rule, {
     validTest('pathsImportWithExtension'),
     validTest('relativeImportIgnoreUnknownExtensions'),
     validTest('relativeImportWithExtension'),
+    validTest('typedPackageImport'),
     validTest('packageTypesImport'),
   ],
 });