feat: support ESLint 9 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Requires Node 18 Also: - chore: use flat config
|
I'm not sure on resolving the failing CI, except that it works with |
|
Looks like lint stop does not work. |
|
Adding |
|
I might have to leave you with the TypeScript... |
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: support ESLint 9
BREAKING CHANGE:
Requires Node 18
Also:
Note that
context.parserPathis being removed per https://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9/#context-properties%3A-parseroptions-and-parserpath-being-removed , and although it mentions a theoretical replacement, I didn't see one being supplied oncontext.languageOptionsorcontext.languageOptions.parserOptions. But the rule seems to work without it.I changed from @typescript-eslint/rule-tester as it does not work with flat configs currently.
I removed a couple duplicate test cases (as that was being warned against).