-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade polkadot v1.7.2 #659
Conversation
New crates:
Crate versions that have been updated:
Runtime version has been increased. |
type GetExchangeFee = ExchangeFee; | ||
type MinTradingLimit = MinTradingLimit; | ||
type MinPoolLiquidity = MinPoolLiquidity; | ||
type MaxInRatio = MaxInRatio; | ||
type MaxOutRatio = MaxOutRatio; | ||
type OracleSource = XYKOracleSourceIdentifier; | ||
type CanCreatePool = pallet_lbp::DisallowWhenLBPPoolRunning<Runtime>; | ||
type CanCreatePool = hydradx_adapters::xyk::AllowPoolCreation<Runtime, AssetRegistry>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm.. suspicious. what happened here? double check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I think it should be fine, it has only strange naming, I changed it to also disallow specific xyk pool creation. So we do the same like in hydraDX
As I was the one who changed it, please someone else do a double check then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be ok as we are reusing hydradx adapter
}, | ||
pallets = { | ||
PolkadotXcm: basilisk_runtime::PolkadotXcm, | ||
Balances: basilisk_runtime::Balances, | ||
} | ||
}, | ||
pub struct OtherParachain { | ||
pub struct OtherPara { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep naming consistent, OtherParachain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I needed to find another name so I could create a helper type so we don't need to change in every tests:
pub type OtherParachain = OtherPara<TestNet>;
The struct is only used directly at this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -269,6 +269,8 @@ async fn start_node_impl( | |||
|
|||
if let Some(hwbench) = hwbench { | |||
sc_sysinfo::print_hwbench(&hwbench); | |||
//TODO: need? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo
type GetExchangeFee = ExchangeFee; | ||
type MinTradingLimit = MinTradingLimit; | ||
type MinPoolLiquidity = MinPoolLiquidity; | ||
type MaxInRatio = MaxInRatio; | ||
type MaxOutRatio = MaxOutRatio; | ||
type OracleSource = XYKOracleSourceIdentifier; | ||
type CanCreatePool = pallet_lbp::DisallowWhenLBPPoolRunning<Runtime>; | ||
type CanCreatePool = hydradx_adapters::xyk::AllowPoolCreation<Runtime, AssetRegistry>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be ok as we are reusing hydradx adapter
type Weigher = FixedWeightBounds<BaseXcmWeight, RuntimeCall, MaxInstructions>; | ||
type BaseXcmWeight = BaseXcmWeight; | ||
type UniversalLocation = UniversalLocation; | ||
type MaxAssetsForTransfer = MaxAssetsForTransfer; | ||
type ReserveProvider = AbsoluteReserveProvider; | ||
type RateLimiter = (); //TODO: what do ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to do something with this ratelimiter at all ? nobody else seems to be using it.
Co-authored-by: Richard Roznovjak <[email protected]>
#[cfg_attr(feature = "std", derive(Serialize, Deserialize))] | ||
pub enum AssetType<AssetId> { | ||
Token, | ||
PoolShare(AssetId, AssetId), // Use XYX instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is deprecated, we could place attribute like
#[deprecated(since = "x.z.y", note = "Use XYK instead")]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would not bother with this anymore. it is older version of registry. it would probably fail on clippy and we would need to allow deprecated anyway
Notable changes
Removed
New pallet:
XCM:
New config params: