feat: Sunset gov v1 #670
Merged
feat: Sunset gov v1 #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Crate versions that have been updated:
Runtime version has been increased. |
mrq1911
approved these changes
Sep 17, 2024
| @@ -170,13 +171,9 @@ construct_runtime!( | |||
| Treasury: pallet_treasury = 4, | |||
| Utility: pallet_utility = 5, | |||
| //NOTE: 6 - is used by Scheduler which must be after cumulus_pallet_parachain_system | |||
| Democracy: pallet_democracy exclude_parts { Config } = 7, | |||
There was a problem hiding this comment.
we should probably retire those pallet id's of removed pallets
There was a problem hiding this comment.
wdym by retire the pallet IDs?
mrq1911
approved these changes
Sep 18, 2024
jak-pan
reviewed
Sep 18, 2024
| @@ -171,12 +172,9 @@ construct_runtime!( | |||
| Utility: pallet_utility = 5, | |||
| //NOTE: 6 - is used by Scheduler which must be after cumulus_pallet_parachain_system | |||
| Democracy: pallet_democracy exclude_parts { Config } = 7, | |||
| Elections: pallet_elections_phragmen = 8, | |||
There was a problem hiding this comment.
We should check the storage after we remove pallets, I think we'll need to clear it either by ref or by migration.
There was a problem hiding this comment.
Ok, I see later we do migration
jak-pan
reviewed
Sep 18, 2024
| @@ -19,29 +19,12 @@ use crate::governance::TechnicalCollective; | |||
| use crate::*; | |||
|
|
|||
| use primitives::constants::{ | |||
| currency::{CENTS, DOLLARS, UNITS}, | |||
| currency::DOLLARS, | |||
There was a problem hiding this comment.
Why remove this and then use imports directly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sunsets gov v1 and the Council, more specifically:
elections-phragmen,tips,collectives/councilpallet-democracyis left in the runtime for now, to be cleaned up later once the existing votes have expired (another max ~3 months)