Dynamic fee tweaks #194
Merged
Dynamic fee tweaks #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_fee_tweaks # Conflicts: # hydradx/tests/test_omnipool_amm.py
poliwop
requested changes
Feb 3, 2025
hydradx/model/amm/omnipool_amm.py
Outdated
| unique_id: str = 'omnipool' | ||
| lrna_mint_pct: float = 1.0, | ||
| unique_id: str = 'omnipool', | ||
| lrna_fee_burn: float = 1.0, |
There was a problem hiding this comment.
Default lrna_fee_burn should be 0.5, since that's what we're doing in PROD. Eventually though we should replace this with parameter sets.
There was a problem hiding this comment.
I think we need lrna_mint_pct to be 1.0 and lrna_fee_burn = 0.5
poliwop
requested changes
Feb 7, 2025
hydradx/model/amm/omnipool_amm.py
Outdated
| unique_id: str = 'omnipool' | ||
| lrna_mint_pct: float = 1.0, | ||
| unique_id: str = 'omnipool', | ||
| lrna_fee_burn: float = 1.0, |
There was a problem hiding this comment.
I think we need lrna_mint_pct to be 1.0 and lrna_fee_burn = 0.5
| liquidity={tkn: self.liquidity[tkn] for tkn in self.liquidity}, | ||
| net_volume=get_last_volume() | ||
| ) | ||
| else: # value is a number |
There was a problem hiding this comment.
I don't find this particular comment clarification very helpful... I think you do have the type hints in the function signature so maybe that's enough.
hydradx/tests/test_omnipool_amm.py
Outdated
| @@ -1375,6 +1317,62 @@ def test_dynamic_fees(hdx_price: float): | |||
| raise AssertionError('LRNA fee should decrease with time.') | |||
|
|
|||
|
|
|||
| @given(num_blocks = st.integers(min_value=1, max_value=1000)) | |||
There was a problem hiding this comment.
Shouldn't this also worth with num_blocks=0? i.e., second transaction in the same block? Can we include this in the test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementing changes to the dynamic fee spec