Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add environment-specific galaxy urls (#239) #241

Merged
merged 6 commits into from
Jan 31, 2025

Conversation

hunterckx
Copy link
Collaborator

@hunterckx hunterckx commented Jan 28, 2025

Things to address:

  • Working production galaxy URLs need to be added
  • Deployment scripts need to be updated to use the correct build scripts

@dannon
Copy link
Member

dannon commented Jan 30, 2025

I've updated this with Galaxy URLs and tweaked the build scripts -- should be good to go now.

@NoopDog
Copy link
Collaborator

NoopDog commented Jan 30, 2025

Thanks @dannon! @hunterckx, can you review Dannons changes, please?

@hunterckx hunterckx marked this pull request as ready for review January 31, 2025 00:43
@hunterckx
Copy link
Collaborator Author

@NoopDog Opened for review, but I notice that there are two scripts, cc-brc-analytics.dev.clevercanary.com-build.sh and psu-brc-analytics.org-build.sh, that are separate from the deployment workflows and still run build:local -- are those unused?

@NoopDog
Copy link
Collaborator

NoopDog commented Jan 31, 2025

Ah the scripts are used. Do they need to be updated @hunterckx ? The prod one is used not so much but the dev one is used to post a test branch to dev and look at it before merging.

@NoopDog
Copy link
Collaborator

NoopDog commented Jan 31, 2025

Ah they should use the dev and prod builds.

@dannon
Copy link
Member

dannon commented Jan 31, 2025

Ahh, missed that -- I assumed we were using the github workflows!

@NoopDog
Copy link
Collaborator

NoopDog commented Jan 31, 2025

Ok, i just updated.

@NoopDog NoopDog merged commit cf9d95d into main Jan 31, 2025
1 check passed
@NoopDog NoopDog deleted the hunter/239-environments branch January 31, 2025 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants