feat: create catalog build python package (#251) #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunterckx
commented
Feb 7, 2025
| genomes_df = add_gene_model_url(genomes_df) | ||
| report_missing_values("accessions", "matched with gene model URLs", genomes_df["accession"], genomes_df["geneModelUrl"].astype(bool)) | ||
| else: | ||
| genomes_df["geneModelUrl"] = "" |
There was a problem hiding this comment.
I've added an option to disable gene model URLs, because the process of getting them can take some time which makes it harder to test changes to the catalog build script -- not certain this will actually come in handy in the future but there were a couple times here where it would've been useful so I figure it's a nice thing to have available
hunterckx
commented
Feb 7, 2025
| if len(missing_values) > 0: | ||
| if len(missing_values) > len(values_series)/2: | ||
| present_values = values_series[present_values_mask] | ||
| print(f"Only {len(present_values)} of {len(values_series)} {values_name} {message_predicate}: {", ".join(present_values)}") |
There was a problem hiding this comment.
If there are more missing values than present values, the present values are reported instead, which makes the message more meaningful in extreme cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #251
Drafted for now in case further updates are needed to support galaxyproject/ga2#23