Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add announcement for the new password component for the registration site #2907

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

add announcement for the new password component for the registration site #2907

wants to merge 2 commits into from

Conversation

Csaern
Copy link

@Csaern Csaern commented Feb 3, 2025 •
edited
Loading

Password_Component_1
Password_Component_2
Password_Component_3

@Csaern Csaern marked this pull request as draft February 3, 2025 19:04
scottcain
scottcain approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@scottcain scottcain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

bgruening
bgruening reviewed Feb 4, 2025
View reviewed changes
content/news/2025-02-03-password-feature/index.md Outdated

The component dynamically assesses password strength based on factors like length, complexity, and uniqueness. It integrates seamlessly into the existing registration workflow, ensuring a smooth and intuitive experience.

Try out the new Password Strength Indicator when registering for a Galaxy account!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"in one of the next Galaxy releases." it not there yet.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay I will change that

bgruening
bgruening reviewed Feb 4, 2025
View reviewed changes
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a screenshot?

@Csaern
Copy link
Author

Csaern commented Feb 4, 2025

Maybe add a screenshot?
I added the screenshots in the description.

@bgruening
Copy link
Member

But I meant as part of the news post.

@Csaern
Copy link
Author

Csaern commented Feb 5, 2025

But I meant as part of the news post.

I added a screenshot and made the requested changes for the announcement.

@bgruening
Copy link
Member

I guess you messed up the merge. Here are commits that do not belong here and the builds are failing.

@Csaern
Copy link
Author

Csaern commented Feb 9, 2025

I guess you messed up the merge. Here are commits that do not belong here and the builds are failing.

i fixed the merge.

@bgruening
Copy link
Member

Thanks, we can merge this when the PR is merged, it looks good to me.

@Csaern Csaern marked this pull request as ready for review February 9, 2025 18:18
@Csaern Csaern marked this pull request as draft February 9, 2025 18:19
@Csaern
Copy link
Author

Csaern commented Feb 9, 2025

Thanks, we can merge this when the PR is merged, it looks good to me.

the commit had a build error. i dont know if the path of the image was incorrect so I made a minor change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgruening bgruening bgruening left review comments

@scottcain scottcain scottcain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Csaern @bgruening @scottcain