Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Jest Test Output (Part 1) #19164

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

jmchilton
Copy link
Member

@jmchilton jmchilton commented Nov 19, 2024

  • Fixes all extraneous output on upload-queue.test.js, fixes test bug, add expectations to ensure errors don't occur during test cases.
  • Fixes all extraneous output on NodeOutput.test.ts
  • Fix extraneous output in Workflow/Editor/Index.test.js - there was an actual bug in our test and a Vue2 warning to suppress. I reviewed the workflow editor activity PR (Workflow Editor Activity Bar #18729) and it doesn't look like this should conflict.
  • Suppress a known, understood console.debug in ToolShed/Repositories/Index.vue
  • Stub out help components that use Bootstrap Vue that expects a valid HTML DOM target that does not exist.
  • Stablize HistoryView.test.js and hide a warning related to scrollIntoView.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

I don't think the test meant to issue the error so I fixed the call and I instrumented the queue to ensure errors don't happen in any of the tests.
@jmchilton jmchilton marked this pull request as ready for review November 19, 2024 22:01
@github-actions github-actions bot added this to the 25.0 milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant