Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonce auth migration #2385

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Nonce auth migration #2385

merged 1 commit into from
Apr 3, 2024

Conversation

Robinnnnn
Copy link
Contributor

@Robinnnnn Robinnnnn commented Mar 27, 2024

Summary of Changes

Migrate auth mechanism on mobile + web to cover:

  • Stateless nonce creation
  • Checking for user existence manually
  • Farcaster auth prep

Checklist

  • web ethereum create account coinbase wallet
  • web ethereum login coinbase wallet
  • web ethereum create account metamask
  • web ethereum login metamask
  • web tezos create account
  • web tezos login
  • mobile ethereum login coinbase wallet
  • mobile ethereum create account coinbase wallet
  • mobile ethereum login metamask
  • mobile ethereum create account metamask

Demo or Before/After Pics

  • If this is a new feature, include screenshots or recordings of the feature in action.
  • If this PR makes visual changes, include before and after screenshots.
Before After

Edge Cases

List any common edge cases that you have considered and tested.

Testing Steps

Provide steps on how the reviewer can test the changes.

Checklist

Please make sure to review and check all of the following:

  • I've tested the changes and all tests pass.
  • (if web) I've tested the changes on various desktop screen sizes to ensure responsiveness.
  • (if mobile) I've tested the changes on both light and dark modes.

Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 5:29am

Copy link

github-actions bot commented Mar 27, 2024

Bundle Sizes

Compared against 03aa4fe

Route: No significant changes found

Dynamic import: No significant changes found

@Robinnnnn Robinnnnn changed the title WIP nonce migration Nonce auth migration Mar 28, 2024
@Robinnnnn Robinnnnn marked this pull request as ready for review March 28, 2024 05:25
@Robinnnnn Robinnnnn merged commit 9882ef1 into main Apr 3, 2024
9 checks passed
@Robinnnnn Robinnnnn deleted the robin/migrate-nonce-auth branch April 3, 2024 18:32
Copy link

sentry-io bot commented Apr 3, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: Please call connect() before enable() useWalletConnect(/Users/slothpotato/Cortana/gal... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant