Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert flag for adding frame for post social links #2389

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

Rohan-cp
Copy link
Collaborator

@Rohan-cp Rohan-cp commented Apr 2, 2024

Summary of Changes

Won't be able to add the mint token button for post frames because the initial button content for frames is sent from here and we only know serverside which token will be shown, so the the changes revert flag for post frames.

Edge Cases

List any common edge cases that you have considered and tested.

Testing Steps

Provide steps on how the reviewer can test the changes.

Checklist

Please make sure to review and check all of the following:

  • I've tested the changes and all tests pass.
  • (if web) I've tested the changes on various desktop screen sizes to ensure responsiveness.
  • (if mobile) I've tested the changes on both light and dark modes.

Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 1:25am

@github-actions github-actions bot added the web label Apr 2, 2024
@Rohan-cp Rohan-cp changed the title base revert flag for adding frame for post social links Apr 2, 2024
Copy link

github-actions bot commented Apr 2, 2024

Bundle Sizes

Compared against c896500

Route: No significant changes found

Dynamic import: No significant changes found

@Robinnnnn Robinnnnn merged commit dd99bfc into main Apr 3, 2024
7 checks passed
@Robinnnnn Robinnnnn deleted the rohan/revert-frame-flag-post-og branch April 3, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants