[GAL-5439] add default state for web search results #2391
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle SizesCompared against fe289b5
Dynamic import: No significant changes found |
Rohan-cp
changed the title
Rohan-cp
changed the title
Rohan-cp
changed the title
| } | ||
|
|
||
| const { bio } = user; | ||
| const unescapedBio = useMemo(() => (bio ? unescape(bio) : ''), [bio]); |
There was a problem hiding this comment.
we shouldn't need to manually unescape on the frontend anymore, the backend should handle this!
There was a problem hiding this comment.
update: the backend unescaping happens in schema.resolvers.helpers.go: https://github.com/gallery-so/go-gallery/pull/1214/files
ask: in a follow-up PR, can you track down all the cases where the frontend calls unescape (screenshot), then ensure the necessary locations in the backend unescapes those fields? the end result should be that we don't call unescape anywhere in the frontend
| const bioFirstLine = useMemo(() => { | ||
| if (!unescapedBio) { | ||
| return ''; | ||
| } | ||
| return unescapedBio.split('\n')[0] ?? ''; | ||
| }, [unescapedBio]); |
There was a problem hiding this comment.
should be able to shortcut the above few lines:
user.bio?.split('\n')[0] ?? ''There was a problem hiding this comment.
nice! made the change and checked it doesn't break anything
Summary of Changes
Provide a brief description of the changes made in this PR. Explain the problem you are fixing or the feature you are adding.
Demo
Screen.Recording.2024-04-05.at.05.58.30.mov
Edge Cases
Moweb
Testing Steps
Provide steps on how the reviewer can test the changes.
Checklist
Please make sure to review and check all of the following: